Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nscd: start in early boot #106336

Closed
wants to merge 1 commit into from
Closed

nixos/nscd: start in early boot #106336

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 8, 2020 •
edited by flokli

Services that have dynamic users require nscd to resolve users
via pam_systemd. Those services might not even create
their own dynamic users itself i.e. iptables.
To make sure nscd is always started when this is happening we move
nscd to sysinit.target and make sure that it is always started before
starting/reloading/restarting any other service.

Fixes: #106127

Motivation for this change

works on my machine (tm)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Dec 8, 2020
Closed
10 tasks
@Mic92
Copy link
Member Author

Mic92 commented Dec 8, 2020

cc @NixOS/systemd

@arianvp arianvp added this to In Progress in systemd Dec 8, 2020
@Mic92
Copy link
Member Author

Mic92 commented Dec 8, 2020

TODO: add some test to test upgrading similar to nixos/tests/acme.nix.

@Mic92
nixos/nscd: start in early boot
18b07c4 
Services that have dynamic users require nscd to resolve users
via pam_systemd. Those services might not even create
their own dynamic users itself i.e. iptables.
To make sure nscd is always started when this is happening we move
nscd to sysinit.target and make sure that it is always started before
starting/reloading/restarting any other service.
@arianvp arianvp mentioned this pull request Dec 14, 2020
Open
@symphorien symphorien mentioned this pull request Jun 3, 2021
Closed
@stale
Copy link

stale bot commented Jun 9, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 9, 2021
@Mic92 Mic92 closed this Jul 23, 2021
@Mic92 Mic92 deleted the nscd branch July 23, 2021 08:29
@symphorien
Copy link
Member

any specific reason to close beyond "this is old" ?

@Mic92
Copy link
Member Author

Mic92 commented Jan 13, 2022

I think this one got reverted by accident. Reopened here: #154928

@Mic92 Mic92 mentioned this pull request Jan 13, 2022
Closed
13 tasks
@flokli flokli moved this from In Progress to Done in systemd Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli flokli left review comments

@arianvp arianvp arianvp left review comments

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 9.needs: tests 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
systemd
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Firewall started before all users created
4 participants
@Mic92 @symphorien @flokli @arianvp