Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pyopenssl: skip test that fails on i686 #106810

Merged
merged 1 commit into from Dec 15, 2020
Merged

pyopenssl: skip test that fails on i686 #106810

merged 1 commit into from Dec 15, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 13, 2020

Found in #105454 (comment)

Upstream issue pyca/pyopenssl#974

Motivation for this change

to make e.g. platformio build again

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof mentioned this pull request Dec 13, 2020
Merged
10 tasks
drewrisinger
drewrisinger approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Build fails on x86-64-linux for obvious reasons: I'm not an i686 machine... Don't have a way to test build otherwise.
error: a 'i686-linux' with features {} is required to build '/nix/store/kw61807r41my731ps4hml21g89a3pfdn-python3.8-pyOpenSSL-20.0.0.drv', but I am a 'x86_64-linux' with features {benchmark, big-parallel, kvm, nixos-test}
https://github.com/NixOS/nixpkgs/pull/106810
2 packages failed to build:
esphome platformio

@raboof
Copy link
Member Author

raboof commented Dec 15, 2020

Build fails on x86-64-linux for obvious reasons: I'm not an i686 machine

I don't have an i686 machine either - I tested with nix-build -A pkgs.pkgsi686Linux.python3.pkgs.pyopenssl

@FRidh FRidh merged commit 40b1f0d into NixOS:master Dec 15, 2020
@B4dM4n B4dM4n mentioned this pull request Jan 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @drewrisinger @FRidh