Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-cli: 2.15.1 -> 2.16.0 #106773

Merged
merged 1 commit into from Dec 17, 2020
Merged

azure-cli: 2.15.1 -> 2.16.0 #106773

merged 1 commit into from Dec 17, 2020

Conversation

anhdle14
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

One thing I am not sure about is whether patching cryptography to 3.3.1 is the correct way or not. But for pyOpenSSL to compile, cryptography must be at least 3.2. Source here: CHANGELOG

@ofborg ofborg bot requested a review from jonringer December 12, 2020 18:43
@anhdle14 anhdle14 mentioned this pull request Dec 15, 2020
Closed
jonringer
jonringer reviewed Dec 16, 2020
View reviewed changes
pkgs/tools/admin/azure-cli/python-packages.nix Outdated Show resolved Hide resolved
pkgs/tools/admin/azure-cli/python-packages.nix Outdated
Comment on lines 396 to 402
cryptography = super.cryptography.overridePythonAttrs(oldAttrs: rec {
version = "2.9.2";
version = "3.3.1";

src = super.fetchPypi {
inherit (oldAttrs) pname;
inherit version;
sha256 = "0af25w5mkd6vwns3r6ai1w5ip9xp0ms9s261zzssbpadzdr05hx0";
sha256 = "1ribd1vxq9wwz564mg60dzcy699gng54admihjjkgs9dx95pw5vy";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just remove the entire pinning to cryptography

@ofborg ofborg bot requested a review from jonringer December 17, 2020 01:20
@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

@anhdle14
Copy link
Contributor Author

@jonringer Thank you for the very informative video, I did what was requested.

jonringer
jonringer approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 106773 run on x86_64-linux 1

1 package built:
  • azure-cli

@jonringer jonringer merged commit 66acfa3 into NixOS:master Dec 17, 2020
@jonringer
Copy link
Contributor

congrats @anhdle14 on your first nixpkgs contribution. Thanks! :)

@anhdle14 anhdle14 deleted the azure-cli-2.16.0 branch December 23, 2020 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anhdle14 @jonringer