Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.cryptography: 2.9.2 -> 3.3.1 #106792

Merged
merged 1 commit into from Dec 14, 2020
Merged

python2Packages.cryptography: 2.9.2 -> 3.3.1 #106792

merged 1 commit into from Dec 14, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Dec 12, 2020

Motivation for this change

Fixes py2 build of pyOpenSSL, unbreaks nixops: #106275 (comment)

cryptography for py3 will be updated to 3.3.1 in #106549. I decided not to remove the pin introduced in #94852 because it will be needed later, since 3.4 will not support py27 (it has been removed on the master branch).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Dec 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/106792
3 packages marked as broken and skipped:
couchdb mailpile pants

4 packages failed to build:
graalvm8 jvmci8 pulseaudio-dlna rainbowstream

33 packages built:
asciidoc-full-with-plugins bitbucket-cli buttersink carddav-util cloudmonkey datadog-agent dd-agent deluge-1_x euca2ools gitAndTools.gitFastExport gnss-sdr gnuradio3_7 gnuradio3_7-unwrapped gr-ais gr-gsm gr-limesdr gr-nacl gr-osmosdr gr-rds kodiPlugins.yatp mercurial_4 mx mysql-workbench nixops nixopsUnstable nixops_1_6_1 ocropus opae python2nix qradiolink trac tsung zabbix-cli

cc @FRidh

@FRidh FRidh requested a review from primeos December 13, 2020 07:41
primeos
primeos approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM and this approach seems like a good idea.

But I hope that NixOps 2.0 will be released before the next stable release because this'll likely only delay the inevitable (Cryptography 3.3.x might also break, become "insecure", etc. at some point).

@orivej-nixos orivej-nixos merged commit 6fa76f0 into NixOS:master Dec 14, 2020
@orivej orivej deleted the cryptography branch March 29, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@orivej @primeos @jonringer @orivej-nixos