-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tfsec: 0.27.0 -> 0.36.10 #106779
tfsec: 0.27.0 -> 0.36.10 #106779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks for making your first contribution to Nixpkgs!
This PR isn't ready for merging yet, but it can be with a few small changes:
- Diff: Diff mostly looks good, see comment below about maintainers
- Commits: since you're adding yourself as a maintainer, this needs separated to a separate commit. Convention in
nixpkgs
is one commit per package/file, wherever possible. - This package builds fine via
nix-review
, so that part is good to go!
@anhdle14 You can & should still have the maintainer commit in this PR if you'd like to be the maintainer, it just needs to be a separate commit (commit & push again) |
@drewrisinger, thank you, @marsam is being requested as well. We can ask whether if he happy to pass it or not. I will create a separate commit if he is ok. Thank you. |
@anhdle14 can you change the commit title to match nixpkgs convention? Something like the PR title (tfsec: 0.27.0 -> 0.36.10) would be great. The information you have there can go on the second line. Also, in nixpkgs we usually call it "bumping" vs "pumping" the version :D |
TFSec github location changed. Also bumping the version to 0.36.10. Signed-off-by: Le Anh Duc <anhdle14@icloud.com>
@drewrisinger Thank you for pointing that out, sorry I did not actually read very carefully the rules yet. This is my first PR for Nixpkgs as well. I fixed it as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the updates. It looks good to me now!
- Diff LGTM
- Commits LGTM
- Builds via
nix-review
on x86_64-linux:
https://github.com/NixOS/nixpkgs/pull/106779
1 package built:
tfsec
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, sorry for the delay
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)