Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tfsec: 0.27.0 -> 0.36.10 #106779

Merged
merged 1 commit into from Dec 27, 2020
Merged

tfsec: 0.27.0 -> 0.36.10 #106779

merged 1 commit into from Dec 27, 2020

Conversation

anhdle14
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@anhdle14 anhdle14 mentioned this pull request Dec 12, 2020
Closed
10 tasks
drewrisinger
drewrisinger suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for making your first contribution to Nixpkgs!

This PR isn't ready for merging yet, but it can be with a few small changes:

  • Diff: Diff mostly looks good, see comment below about maintainers
  • Commits: since you're adding yourself as a maintainer, this needs separated to a separate commit. Convention in nixpkgs is one commit per package/file, wherever possible.
  • This package builds fine via nix-review, so that part is good to go!

pkgs/development/tools/analysis/tfsec/default.nix Outdated Show resolved Hide resolved
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
@drewrisinger
Copy link
Contributor

@anhdle14 You can & should still have the maintainer commit in this PR if you'd like to be the maintainer, it just needs to be a separate commit (commit & push again)

@ofborg ofborg bot requested a review from marsam December 15, 2020 00:52
@anhdle14
Copy link
Contributor Author

@drewrisinger, thank you, @marsam is being requested as well. We can ask whether if he happy to pass it or not. I will create a separate commit if he is ok. Thank you.

@drewrisinger
Copy link
Contributor

@anhdle14 can you change the commit title to match nixpkgs convention? Something like the PR title (tfsec: 0.27.0 -> 0.36.10) would be great. The information you have there can go on the second line. Also, in nixpkgs we usually call it "bumping" vs "pumping" the version :D

@anhdle14
tfsec: 0.27.0 -> 0.36.10
8cea3c4 
TFSec github location changed. Also bumping the version to 0.36.10.

Signed-off-by: Le Anh Duc <anhdle14@icloud.com>
@anhdle14
Copy link
Contributor Author

@anhdle14 can you change the commit title to match nixpkgs convention? Something like the PR title (tfsec: 0.27.0 -> 0.36.10) would be great. The information you have there can go on the second line. Also, in nixpkgs we usually call it "bumping" vs "pumping" the version :D

@drewrisinger Thank you for pointing that out, sorry I did not actually read very carefully the rules yet. This is my first PR for Nixpkgs as well. I fixed it as requested.

drewrisinger
drewrisinger approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the updates. It looks good to me now!

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86_64-linux:
https://github.com/NixOS/nixpkgs/pull/106779
1 package built:
tfsec

marsam
marsam approved these changes Dec 27, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, sorry for the delay

@marsam marsam merged commit e8ee6c3 into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anhdle14 @drewrisinger @marsam