Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.zigpy: 0.26.0 -> 0.28.2, python3Packages.aiosqlite: 0.12.0 -> 0.16.0, python3Packages.zha-quirks: 0.0.47 -> 0.0.48, fix tests #106778

Closed
wants to merge 3 commits into from
Closed

python3Packages.zigpy: 0.26.0 -> 0.28.2, python3Packages.aiosqlite: 0.12.0 -> 0.16.0, python3Packages.zha-quirks: 0.0.47 -> 0.0.48, fix tests #106778

wants to merge 3 commits into from

Conversation

mvnetbiz
Copy link
Contributor

Motivation for this change

Fix zigpy modules

Things done
  • Updated zigpy
  • updated aiosqlite
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mvnetbiz
Copy link
Contributor Author

zha-quirks is also broken again, let me fix that first.

@ofborg ofborg bot requested review from costrouc and etu December 12, 2020 19:09
@mvnetbiz
Copy link
Contributor Author

I have some other problem preventing me from loading my complete Homeassistant config, but this loads the zha component in a vm fine.

@mvnetbiz mvnetbiz changed the title python3Packages.zigpy: 0.26.0 -> 0.28.1, python3Packages.aiosqlite: 0.12.0 -> 0.16.0 python3Packages.zigpy: 0.26.0 -> 0.28.2, python3Packages.aiosqlite: 0.12.0 -> 0.16.0, python3Packages.zha-quirks: 0.0.47 -> 0.0.48, fix tests Dec 12, 2020
@mvnetbiz
Copy link
Contributor Author

Result of nixpkgs-review pr 106778 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python39Packages.databases
  • python39Packages.fastapi
  • python39Packages.orm
  • python39Packages.starlette
8 packages failed to build:
  • python37Packages.databases
  • python37Packages.fastapi
  • python37Packages.orm
  • python37Packages.starlette
  • python38Packages.databases
  • python38Packages.fastapi
  • python38Packages.orm
  • python38Packages.starlette
24 packages built:
  • python37Packages.aiosqlite
  • python37Packages.bellows
  • python37Packages.zha-quirks
  • python37Packages.zigpy
  • python37Packages.zigpy-deconz
  • python37Packages.zigpy-znp
  • python38Packages.aiosqlite
  • python38Packages.bellows
  • python38Packages.zha-quirks
  • python38Packages.zigpy
  • python38Packages.zigpy-cc
  • python38Packages.zigpy-deconz
  • python38Packages.zigpy-xbee
  • python38Packages.zigpy-zigate
  • python38Packages.zigpy-znp
  • python39Packages.aiosqlite
  • python39Packages.bellows
  • python39Packages.zha-quirks
  • python39Packages.zigpy
  • python39Packages.zigpy-cc
  • python39Packages.zigpy-deconz
  • python39Packages.zigpy-xbee
  • python39Packages.zigpy-zigate
  • python39Packages.zigpy-znp

@mweinelt mweinelt mentioned this pull request Jan 6, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106778 run on x86_64-linux 1

4 packages marked as broken and skipped:
8 packages failed to build:

  • python37Packages.databases
  • python37Packages.fastapi
  • python37Packages.orm
  • python37Packages.starlette
  • python38Packages.databases
  • python38Packages.fastapi
  • python38Packages.orm
  • python38Packages.starlette

24 packages built:

The build failures should be fixed in one of my big python PRs.

@mweinelt
Copy link
Member

mweinelt commented Jan 6, 2021 •
edited

I'm sorry I missed this, it was WIP when I first looked at it and I didn't notice when it was finished. By now the most recent version of home-assistant depends on even newer versions, e.g.:

homeassistant/components/zha/manifest.json
13:    "zigpy==0.29.0",
homeassistant/components/zha/manifest.json
10:    "zha-quirks==0.0.51",

Superseded by #108602 .

@mweinelt mweinelt closed this Jan 6, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106778 run on x86_64-linux 1

4 packages marked as broken and skipped:
  • python39Packages.databases
  • python39Packages.fastapi
  • python39Packages.orm
  • python39Packages.starlette
1 package failed to build and are new build failure:
  • python38Packages.orm: log was empty
31 packages built:
  • python37Packages.aiosqlite
  • python37Packages.bellows
  • python37Packages.databases
  • python37Packages.fastapi
  • python37Packages.orm
  • python37Packages.starlette
  • python37Packages.zha-quirks
  • python37Packages.zigpy
  • python37Packages.zigpy-deconz
  • python37Packages.zigpy-znp
  • python38Packages.aiosqlite
  • python38Packages.bellows
  • python38Packages.databases
  • python38Packages.fastapi
  • python38Packages.starlette
  • python38Packages.zha-quirks
  • python38Packages.zigpy
  • python38Packages.zigpy-cc
  • python38Packages.zigpy-deconz
  • python38Packages.zigpy-xbee
  • python38Packages.zigpy-zigate
  • python38Packages.zigpy-znp
  • python39Packages.aiosqlite
  • python39Packages.bellows
  • python39Packages.zha-quirks
  • python39Packages.zigpy
  • python39Packages.zigpy-cc
  • python39Packages.zigpy-deconz
  • python39Packages.zigpy-xbee
  • python39Packages.zigpy-zigate
  • python39Packages.zigpy-znp

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python37Packages.zigpy-deconz:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.zigpy-deconz:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.bellows:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.zigpy-deconz:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

orm is being fixed in another pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mweinelt mweinelt Awaiting requested review from mweinelt

@costrouc costrouc Awaiting requested review from costrouc

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvnetbiz @SuperSandro2000 @mweinelt