Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scribusUnstable: build with libsForQt5 #106781

Merged
merged 1 commit into from Dec 15, 2020
Merged

scribusUnstable: build with libsForQt5 #106781

merged 1 commit into from Dec 15, 2020

Conversation

erictapen
Copy link
Member

See #104474

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kiwi Kiwi self-requested a review December 14, 2020 05:26
drewrisinger
drewrisinger reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86-64-linux:
https://github.com/NixOS/nixpkgs/pull/106781
1 package built:
scribusUnstable

Didn't really test beyond this b/c I'm on a headless machine, hence lack of approve/request.

@Kiwi
Copy link
Member

Kiwi commented Dec 15, 2020

I built it on aarch64-linux (not yet tested, I can get on a pi later but haven't yet) and x86_64-linux (launched, LGTM)

unrelated; I attempted x86_64-darwin for kicks since it is currently unsupported and fails but I think it's possible to so I'll try and get working eventually now that I have a darwin builder and am trying to get everything I can supported >.>

@erictapen
Copy link
Member Author

@Kiwi nice, good luck with supporting darwin!

I'll merge this then.

@erictapen erictapen merged commit 3d3c070 into NixOS:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger left review comments

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @Kiwi @drewrisinger