Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alttpr-opentracker: init at 1.6.1 #106789

Closed
wants to merge 2 commits into from

Conversation

IslandUsurper
Copy link

Motivation for this change

Add desktop tracker of game state of A Link to the Past Randomizer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@IslandUsurper
Copy link
Author

Note: I'm not entirely certain I've named everything correctly. The upstream is "OpenTracker", but there's already a Bittorrent thing called "opentracker" in nixpkgs. I took the liberty of referring to this package as "alttpr-opentracker" since it's specifically for A Link to the Past Randomizer.

Comment on lines +1 to +2
{ stdenv, fetchurl, autoPatchelfHook, makeWrapper, wrapGAppsHook,
curl, dotnet-netcore, dpkg, fontconfig, gcc, gsettings-desktop-schemas, gtk3, lttng-ust, openssl, xorg }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchurl, autoPatchelfHook, makeWrapper, wrapGAppsHook,
curl, dotnet-netcore, dpkg, fontconfig, gcc, gsettings-desktop-schemas, gtk3, lttng-ust, openssl, xorg }:
{ stdenv, fetchurl, autoPatchelfHook, makeWrapper, wrapGAppsHook
, curl, dotnet-netcore, dpkg, fontconfig, gcc, gsettings-desktop-schemas, gtk3, lttng-ust, openssl, xorg }:

--prefix LD_LIBRARY_PATH : ${ld_path}
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@IvarWithoutBones
Copy link
Member

With #142919 being merged, this can be closed now.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 26, 2021
@IslandUsurper
Copy link
Author

So moved. Thanks, @IvarWithoutBones!

@IvarWithoutBones
Copy link
Member

No problem 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants