Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/prometheus-exporters/py-air-control: invoke exporter command #106788

Merged
merged 1 commit into from Dec 12, 2020
Merged

nixos/prometheus-exporters/py-air-control: invoke exporter command #106788

merged 1 commit into from Dec 12, 2020

Conversation

urbas
Copy link
Contributor

@urbas urbas commented Dec 12, 2020 •
edited

Motivation for this change

Package py-air-control exporter v0.1.5 comes with a new CLI. This change uses the new CLI, which simplifies the exporter's systemd service setup.

Things done

  1. Tested by deploying this change on a live server (Raspberry Pi 4).

  2. Tested via nix-build -vA pkgs.nixosTests.prometheus-exporters.py-air-control

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @WilliButz

@urbas
nixos/prometheus-exporters/py-air-control: invoke exporter command
4970fbe 
Package `py-air-control exporter` v0.1.5 comes with a new CLI. This change uses the new CLI (which simplifies the exporter's systemd service setup).
@WilliButz
Copy link
Member

@GrahamcOfBorg test prometheus-exporters.py-air-control

WilliButz
WilliButz approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WilliButz WilliButz merged commit 8727a01 into NixOS:master Dec 12, 2020
@urbas urbas deleted the py-air-control-exporter-cli branch December 29, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliButz WilliButz WilliButz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urbas @WilliButz