protontricks: 1.4.2 -> 1.4.3 #106800
Merged
protontricks: 1.4.2 -> 1.4.3 #106800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to reduce closure size when a wrapper uses a custom WINE at runtime, or a different wine in PATH. See pkgs/tools/package-management/protontricks/default.nix
Reduces closure size by 1.8G
|
Result of 1 package built:protontricks Tested and worked. Only issue is Winetricks not being on a recent version (#107433 should solve it) [nix-shell:~/.cache/nixpkgs-review/pr-106800-1]$ protontricks --gui
winetricks GUI enabled, using zenity 3.32.0
------------------------------------------------------
You are running winetricks-20200412, latest upstream is winetricks-20201206!
------------------------------------------------------
------------------------------------------------------
You should update using your distribution's package manager, --self-update, or manually.
------------------------------------------------------ |
WolfangAukang
approved these changes
Dec 23, 2020
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
Result of 1 package built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Upgrade to the latest version: https://github.com/Matoking/protontricks/releases/tag/1.4.3
Also, now uses steam-run to run Proton wine instead of wineWowPackages.minimal.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)protontricks --helpprotontricks --guiprotontricks 8190 d3dcompiler_43 d3dx10nix path-info -Sbefore and after)1.8G -> 2.3G (1.8 -> 4.1G without removing default build of wine from winetricks)
Effectively 1.8G -> 459.6M, since anyone using protontricks should already have steam & it's runtime installed.