Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stlink: Correct comment about the use of services.udev.packages #105874

Merged
merged 1 commit into from Dec 4, 2020
Merged

stlink: Correct comment about the use of services.udev.packages #105874

merged 1 commit into from Dec 4, 2020

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented Dec 4, 2020

services.udev.pkgs does not exists, but services.udev.packages does.

Motivation for this change

It's not possible to simply copy&paste the comment to configuration.nix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wentasah
stlink: Correct comment about the use of services.udev.packages
9928e07 
services.udev.pkgs does not exists, but services.udev.packages does.
@SuperSandro2000 SuperSandro2000 merged commit 3d7619f into NixOS:master Dec 4, 2020
@wentasah wentasah deleted the stlink-fix-comment branch December 4, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evils evils evils approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wentasah @evils @SuperSandro2000