Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clucene_core*: Make multi output #105875

Closed
wants to merge 2 commits into from
Closed

clucene_core*: Make multi output #105875

wants to merge 2 commits into from

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Dec 4, 2020 •
edited

Motivation for this change

This removes header files from the runtime closure of dependants.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105875 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • odpdown
  • soprano
  • sword
3 packages failed to build:
  • dovecot
  • dovecot_fts_xapian
  • dovecot_pigeonhole
1 package built:
  • clucene_core_2

dovecot:

E=2 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -I/nix/store/3936fim2vmpsbxr8n64r6dl41achis67-openssl-1.1.1h-dev/include      -o test-iostream-ssl test-iostream-ssl.o libssl_iostream_openssl.la libssl_iostream.la ../lib-test/libtest.la ../lib/liblib.la -L/nix/store/b3hnjdhaxfk7xkbwaww0qcxmjfsg90jk-openssl-1.1.1h/lib -lssl -lcrypto

*** Warning: Linking the executable test-iostream-ssl against the loadable module
*** libssl_iostream_openssl.so is not portable!
libtool: link: clang -std=gnu99 -g -O2 -fstack-protector-strong -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -W -Wmissing-prototypes -Wmissing-declarations -Wpointer-arith -Wchar-subscripts -Wformat=2 -Wbad-function-cast -Wno-duplicate-decl-specifier -Wstrict-aliasing=2 -I/nix/store/3936fim2vmpsbxr8n64r6dl41achis67-openssl-1.1.1h-dev/include -o .libs/test-iostream-ssl test-iostream-ssl.o  ./.libs/libssl_iostream_openssl.so -L/nix/store/b3hnjdhaxfk7xkbwaww0qcxmjfsg90jk-openssl-1.1.1h/lib ./.libs/libssl_iostream.a ../lib-test/.libs/libtest.a ../lib/.libs/liblib.a -lssl -lcrypto
ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) file './.libs/libssl_iostream_openssl.so' for architecture x86_64
clang-7: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [Makefile:638: test-iostream-ssl] Error 1
make[3]: Leaving directory '/private/tmp/nix-build-dovecot-2.3.11.3.drv-0/dovecot-2.3.11.3/src/lib-ssl-iostream'
make[2]: *** [Makefile:566: all-recursive] Error 1
make[2]: Leaving directory '/private/tmp/nix-build-dovecot-2.3.11.3.drv-0/dovecot-2.3.11.3/src'
make[1]: *** [Makefile:684: all-recursive] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-dovecot-2.3.11.3.drv-0/dovecot-2.3.11.3'
make: *** [Makefile:528: all] Error 2

@adisbladis
clucene_core_2: Make multi output
97f10da 
This removes header files from the run time closure of any dependants.
@adisbladis
clucene_core: Make multi output
7739990 
This removes header files from the run time closure of any dependants.
@stale
Copy link

stale bot commented Aug 13, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 13, 2021
@adisbladis adisbladis closed this Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adisbladis @SuperSandro2000