Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 645694199368
Choose a base ref
...
head repository: NixOS/nix
compare: 8d65ec545764
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Dec 4, 2020

  1. When moving paths out of sandbox, ensure we have write permission. 

    If we're a single-user installation of Nix, then we won't have root
superpowers to just ignore the permission bits. This means that we'll
need permission on the directory (if it's a directory) that we're moving
in order to move it with rename, because it must update the ".."
directory entry.

Fixes #4295.

This is already working in master, thanks to
e913a29 (and followup cleanups).
    @lukegb
    lukegb committed Dec 4, 2020
    Copy the full SHA
    2239953 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4312 from lukegb/bug4295 

    When moving paths out of sandbox, ensure we have write permission
    @edolstra
    edolstra committed Dec 4, 2020
    Copy the full SHA
    8d65ec5 View commit details
    Browse the repository at this point in the history