Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staruml: mark broken cause it is packaged incorrectly #105855

Closed
wants to merge 1 commit into from
Closed

staruml: mark broken cause it is packaged incorrectly #105855

wants to merge 1 commit into from

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
tree /nix/store/87jczkcc295x7yqygx45yxci9qvzjj7s-staruml-2.8.1/bin/
appshell128.png         appshell48.png          cef.pak                 locales/                samples/                staruml.desktop         www/
appshell256.png         Brackets-node           devtools_resources.pak  node-core/              staruml                 .StarUML-wrapped
appshell32.png          .Brackets-node-wrapped  lib/                    profiles/               StarUML                 templates/
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

gebner
gebner requested changes Dec 4, 2020
View reviewed changes
Copy link
Member

@gebner gebner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this should be marked broken. It builds fine, and runs fine as well.

But yes, the deb package shouldn't be extracted to $out/bin.

@SuperSandro2000 SuperSandro2000 deleted the staruml branch December 23, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner gebner requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @gebner