Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd: 247 -> 247.1 #106834

Merged
merged 1 commit into from Dec 13, 2020
Merged

systemd: 247 -> 247.1 #106834

merged 1 commit into from Dec 13, 2020

Conversation

chvp
Copy link
Member

@chvp chvp commented Dec 13, 2020 •
edited

Motivation for this change

Should fix #106791, as far as I can tell. I've targeted staging, since as far as I know, that's where a rebuild of this size should end up.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from flokli, edolstra and andir December 13, 2020 15:53
@chvp
Copy link
Member Author

chvp commented Dec 13, 2020

Running this successfully on the two servers I was having problems on. Everything seems stable so far, but the segfault happened after a seemingly random amount of time, so 🤷‍♀️.

@flokli
Copy link
Contributor

flokli commented Dec 13, 2020

I also ran some tests here. Let's get this into staging.

@flokli flokli merged commit d43d150 into NixOS:staging Dec 13, 2020
@chvp chvp deleted the fix/systemd-247.1 branch December 13, 2020 19:11
@Kloenk Kloenk mentioned this pull request Dec 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@edolstra edolstra Awaiting requested review from edolstra

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chvp @flokli