Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.python-utils: remove unmaintained pytestpep8 dependency #106835

Closed
wants to merge 1 commit into from
Closed

python3Packages.python-utils: remove unmaintained pytestpep8 dependency #106835

wants to merge 1 commit into from

Conversation

gebner
Copy link
Member

@gebner gebner commented Dec 13, 2020

Motivation for this change

cura didn't build.

The pytestpep8 package is unmaintained and broken with the latest pytest version (AFAICT). Other packages are probably broken as well because they depend on pytestpep8.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gebner
Copy link
Member Author

gebner commented Dec 13, 2020

Apparently we already have a bug for this: #106579

This PR now contains @drewrisinger's fix from that PR.

@gebner
Copy link
Member Author

gebner commented Dec 13, 2020

Closed in favor of #106579, which actually fixes all of the pytestpep8 breakage (no idea why it was still marked draft).

@gebner gebner closed this Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gebner