Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qusb2snes: init at 0.7.19.1 #106836

Closed
wants to merge 2 commits into from
Closed

qusb2snes: init at 0.7.19.1 #106836

wants to merge 2 commits into from

Conversation

IslandUsurper
Copy link

Motivation for this change

Enable auto-tracking, netplay, etc for SNES emulators.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@neonfuz
Copy link
Contributor

neonfuz commented Dec 13, 2020

I took a quick look at the changes, it all looks good but I suggest using fetchFromGitHub over fetchTarball when fetching from github, idr why but it's preferred (something like faster downloads).

IvarWithoutBones
IvarWithoutBones requested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@IvarWithoutBones IvarWithoutBones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor problems, otherwise LGTM :)

pkgs/applications/networking/qusb2snes/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/qusb2snes/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/qusb2snes/default.nix Show resolved Hide resolved
@IslandUsurper
Copy link
Author

Thanks for the reviews. All suggestions have been implemented. Sorry for forgetting meta.

SuperSandro2000
SuperSandro2000 reviewed Jan 18, 2021
View reviewed changes
pkgs/applications/networking/qusb2snes/default.nix

meta = with lib; {
description = "A Qt based webserver for usb2snes";
license = licenses.gpl3Only;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

homepage missing.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@IvarWithoutBones IvarWithoutBones IvarWithoutBones requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@IslandUsurper @neonfuz @SuperSandro2000 @IvarWithoutBones