Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmuxPlugins.jump: fix ruby dependency #105733

Merged
merged 1 commit into from Dec 27, 2020
Merged

tmuxPlugins.jump: fix ruby dependency #105733

merged 1 commit into from Dec 27, 2020

Conversation

arnarg
Copy link
Contributor

@arnarg arnarg commented Dec 2, 2020

Motivation for this change

I missed a Ruby dependency in one of the scripts in tmux-jump when adding the plugin in #105386.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105733 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.jump

@arnarg
Copy link
Contributor Author

arnarg commented Dec 16, 2020

Is anything blocking this?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105733 run on x86_64-linux 1

1 package built:
  • tmuxPlugins.jump

gpl3 is a deprecated license, check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

@SuperSandro2000 SuperSandro2000 merged commit 4c7b05e into NixOS:master Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnarg @SuperSandro2000