New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
idevicerestore: Add darwin build support. #105722
Conversation
ddc6ded
to
fc232d6
Compare
fc232d6
to
a4d7b93
Compare
@SuperSandro2000 thanks for the quick review! |
a4d7b93
to
e4b9653
Compare
One PR for this fine but please put each package change into a separate commit so it could be easily backported. |
Ok cool. I'll turn this into a few commits then :) |
e4b9653
to
7319dc2
Compare
Result of 5 packages built:
|
@rb2k welcome to the club! |
Motivation for this change
I saw that in the original derivation the comment mentioned darwin should be theoretically supported but it wasn't tested.
I tested it and it compiles fine and can run a few basic CLI commands.
I had to add the darwin flag to a few of the dependencies as well. Not sure if that needs to go into a separate PR?
(This is my first nixpkg contribution, so a sanity check would be appreciated 馃槂 )
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)