Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libslirp: 4.3.1 -> 4.4.0 #105730

Merged
merged 1 commit into from Dec 3, 2020
Merged

libslirp: 4.3.1 -> 4.4.0 #105730

merged 1 commit into from Dec 3, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 2, 2020

https://gitlab.freedesktop.org/slirp/libslirp/-/releases/v4.4.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Dec 3, 2020
View reviewed changes
pkgs/development/libraries/libslirp/default.nix
};

patches = [
# remove >4.3.1
(fetchpatch {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove fetchpatch from the inputs.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105730 run on x86_64-linux 1

4 packages built:
  • buildah
  • libslirp
  • podman
  • slirp4netns

@zowoq
Copy link
Contributor Author

zowoq commented Dec 3, 2020 •
edited

slirp4netns doesn't have any code changes but I'll bump it here as we're already doing a rebuild and the bot will eventually send a PR for it anyway.

I'll merge #105776

@zowoq zowoq changed the title libslirp: 4.3.1 -> 4.4.0 libslirp: 4.3.1 -> 4.4.0, slirp4netns: 1.1.7 -> 1.1.8 Dec 3, 2020
@zowoq zowoq changed the title libslirp: 4.3.1 -> 4.4.0, slirp4netns: 1.1.7 -> 1.1.8 libslirp: 4.3.1 -> 4.4.0 Dec 3, 2020
saschagrunert
saschagrunert approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zowoq zowoq merged commit ae1f466 into NixOS:master Dec 3, 2020
@zowoq zowoq deleted the libslirp branch December 3, 2020 09:45
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105730 run on x86_64-darwin 1

1 package built:
  • libslirp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@saschagrunert saschagrunert saschagrunert approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @SuperSandro2000 @saschagrunert