Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kodi: accept plugins without extraRuntimeDependencies #105741

Merged
merged 1 commit into from Dec 11, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Dec 3, 2020

Motivation for this change

Certain kodi plugins that you can install imperatively from within kodi itself have python dependencies which must be in PYTHONPATH. For example, the plugin.video.netflix plugin requires pycryptodomex. Sure, this PR may be considered a tiny bit hacky, but I thought pushing these python dependencies into kodi via the plugins directive seemed reasonable 🤷‍♂️

kodi.override { plugins = with kodiPlugins; [ python2Packages.pycryptodomex ]; }'

Without this PR I have to hack in the extraRuntimeDependencies like so:

kodi.override { plugins = with kodiPlugins; [ (python2Packages.pycryptodomex // { extraRuntimeDependencies = []; }) ]; }'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000 SuperSandro2000 merged commit 6704a98 into NixOS:master Dec 11, 2020
@aanderse aanderse deleted the kodi-python branch December 11, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants