Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinnamon.muffin: 4.6.3 -> 4.8.0 #105736

Closed
wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Dec 2, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/muffin/versions.

meta.description for cinnamon.muffin is: "The window management library for the Cinnamon desktop (libmuffin) and its sample WM binary (muffin)"

meta.homepage for cinnamon.muffin is: "https://github.com/linuxmint/muffin"

meta.changelog for cinnamon.muffin is: ""

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)

Rebuild report (if merged into master) (click to expand)
10 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
cinnamon.cinnamon-common
cinnamon.cinnamon-gsettings-overrides
cinnamon.cinnamon-screensaver
cinnamon.muffin
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/xrcqzzc433h20cla1b68x51jd87zh9m0-muffin-4.8.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A cinnamon.muffin https://github.com/r-ryantm/nixpkgs/archive/d99076e70c75cb7422ac2a31cf01f999cbdfa15a.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/xrcqzzc433h20cla1b68x51jd87zh9m0-muffin-4.8.0
ls -la /nix/store/xrcqzzc433h20cla1b68x51jd87zh9m0-muffin-4.8.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

4 packages built:
  • cinnamon.cinnamon-common
  • cinnamon.cinnamon-gsettings-overrides
  • cinnamon.cinnamon-screensaver
  • cinnamon.muffin

Maintainer pings

cc @mkg20001 for testing.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds clean via nix-review. Don't have GUI PC w/ nix to test it on.
https://github.com/NixOS/nixpkgs/pull/105736
4 packages built:
cinnamon.cinnamon-common cinnamon.cinnamon-gsettings-overrides cinnamon.cinnamon-screensaver cinnamon.muffin

@mkg20001
Copy link
Member

mkg20001 commented Dec 3, 2020

I'm not happy with 4.6 and 4.8 being merged as nobody tests if the desktop actually works. Rather it should follow the practice of gnome to have a big PR that switches major versions with all packages updated at once.

Copy link
Member

@mkg20001 mkg20001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NACK - will pull this commit in while upgrading & testing the whole thing

Copy link
Member

@mkg20001 mkg20001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryantm
Copy link
Member

ryantm commented Dec 3, 2020

@mkg20001 would you like me to skip updating cinnamon with nixpkgs-update? Jotjnar turns it off during GNOME release cycles but back on during regular times.

@mkg20001
Copy link
Member

mkg20001 commented Dec 3, 2020

Yes, that would be good. Currently working on the updates locally.

Is there any way to run the bot locally so I don't have to do it manually since cinnamon doesn't yet have an update script?

@ryantm
Copy link
Member

ryantm commented Dec 3, 2020

Yes, that would be good. Currently working on the updates locally.

Okay, I'll try to add it to the skip lists soon.

Is there any way to run the bot locally so I don't have to do it manually since cinnamon doesn't yet have an update script?

Yes, there are instructions in the nixpkgs-update readme but I'd recommend trying nix-update first.

@ryantm
Copy link
Member

ryantm commented Dec 10, 2020

@mkg20001 All cinnamon packages are skipped now nix-community/nixpkgs-update@78236b7

@r-ryantm r-ryantm deleted the auto-update/muffin branch March 21, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants