New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cinnamon.muffin: 4.6.3 -> 4.8.0 #105736
cinnamon.muffin: 4.6.3 -> 4.8.0 #105736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Builds clean via
nix-review
. Don't have GUI PC w/ nix to test it on.
https://github.com/NixOS/nixpkgs/pull/105736
4 packages built:
cinnamon.cinnamon-common cinnamon.cinnamon-gsettings-overrides cinnamon.cinnamon-screensaver cinnamon.muffin
I'm not happy with 4.6 and 4.8 being merged as nobody tests if the desktop actually works. Rather it should follow the practice of gnome to have a big PR that switches major versions with all packages updated at once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NACK - will pull this commit in while upgrading & testing the whole thing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkg20001 would you like me to skip updating cinnamon with nixpkgs-update? Jotjnar turns it off during GNOME release cycles but back on during regular times. |
Yes, that would be good. Currently working on the updates locally. Is there any way to run the bot locally so I don't have to do it manually since cinnamon doesn't yet have an update script? |
Okay, I'll try to add it to the skip lists soon.
Yes, there are instructions in the nixpkgs-update readme but I'd recommend trying nix-update first. |
@mkg20001 All cinnamon packages are skipped now nix-community/nixpkgs-update@78236b7 |
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/muffin/versions.
meta.description for cinnamon.muffin is: "The window management library for the Cinnamon desktop (libmuffin) and its sample WM binary (muffin)"
meta.homepage for cinnamon.muffin is: "https://github.com/linuxmint/muffin"
meta.changelog for cinnamon.muffin is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
built on NixOS
The tests defined in
passthru.tests
, if any, passed0 of 0 passed binary check by having a zero exit code.
0 of 0 passed binary check by having the new version present in output.
found 4.8.0 with grep in /nix/store/xrcqzzc433h20cla1b68x51jd87zh9m0-muffin-4.8.0
directory tree listing: https://gist.github.com/f30a752ff7cdeeda7746b9dd705bfb6d
du listing: https://gist.github.com/d605476d2578d50f9b6481154e8f54de
Rebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
14 packages built:
Maintainer pings
cc @mkg20001 for testing.