Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert steam documentation to common mark #105728

Merged
merged 1 commit into from Dec 23, 2020
Merged

Convert steam documentation to common mark #105728

merged 1 commit into from Dec 23, 2020

Conversation

Stupremee
Copy link
Member

Motivation for this change

Resolves #105262

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm ryantm force-pushed the steam-common-mark-conversion branch from 0eddab1 to 897580d Compare December 23, 2020 04:33
@ryantm ryantm force-pushed the steam-common-mark-conversion branch from 897580d to 357f132 Compare December 23, 2020 04:35
ryantm
ryantm approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rebased this to fix the trivial merge conflict and the commit message. Code, rendering, and diff all look good. Good work!

@ryantm ryantm merged commit b7eef7b into NixOS:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berbiche berbiche berbiche left review comments

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Steam from Docbook to CommonMark
3 participants
@Stupremee @ryantm @berbiche