Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sd-image: fix resizing if root is not the second partition. #105732

Merged
merged 1 commit into from Dec 3, 2020
Merged

sd-image: fix resizing if root is not the second partition. #105732

merged 1 commit into from Dec 3, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Dec 2, 2020 •
edited

Motivation for this change

This is useful when using: https://github.com/Mic92/nixos-aarch64-images

Disclaimer I only evaluated the bash code manually. I have not fully run the whole image.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Dec 2, 2020
Closed
@Mic92
Copy link
Member Author

Mic92 commented Dec 3, 2020

We tested this in Mic92/nixos-aarch64-images#1 on a raspberry pi and on a rock64.

@Mic92 Mic92 merged commit 0f593fc into NixOS:master Dec 3, 2020
@Mic92 Mic92 deleted the resizing branch December 3, 2020 06:59
@Mic92
Copy link
Member Author

Mic92 commented Dec 3, 2020

backport: 1d957fd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92