nixos/mpd: conditionally provision required directories with StateDirectory #106697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
stateDir
deviates from the expected value (/var/lib/mpd
)... also we don't have the ability to understand what the filesystem looks in order to make the right choicesstateDir
, resulting in various permissions issues:systemd.tmpfiles.rules
generally doesn't behave as most users would expect[ "d /a foo foo" "d /a/b/c foo foo" ]
produces an error (rightfully so) because/a/b
would be owned byroot:root
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)