Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/mpd: conditionally provision required directories with StateDirectory #106697

Merged
merged 1 commit into from Dec 12, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Dec 12, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar changed the title nixos/mpd: conditionally provision required directories with StateDir… nixos/mpd: conditionally provision required directories with StateDirectory Dec 12, 2020
@doronbehar
Copy link
Contributor

OK I think I got convinced that StateDirectory is better for the simple cases of NixOS' modules. Quoting systemd.exec(1):

tmpfiles.d(5) provides functionality that overlaps with these options. Using these options is recommended, because the lifetime of the directories is tied directly to the lifetime of the unit, and it is not necessary to ensure that the tmpfiles.d configuration is executed before the unit is started.

And I also think it won't affect existing users that do nothing besides using the defaults. It didn't even affect me which I was using tmpfiles rules on these directories.

@flokli flokli merged commit ce0fdd4 into NixOS:master Dec 12, 2020
@aanderse aanderse deleted the mpd branch December 12, 2020 19:50
@aanderse aanderse mentioned this pull request Jan 14, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants