Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk_9: qt514 -> qt515 #106677

Merged
merged 1 commit into from Dec 15, 2020
Merged

vtk_9: qt514 -> qt515 #106677

merged 1 commit into from Dec 15, 2020

Conversation

tfmoraes
Copy link
Contributor

Motivation for this change

As requested in #104474

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
❯ nix-shell -p nixpkgs-review --run "nixpkgs-review wip"                                                                
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
remote: Enumerating objects: 50, done.
remote: Counting objects: 100% (50/50), done.
remote: Compressing objects: 100% (12/12), done.
remote: Total 54 (delta 43), reused 44 (delta 38), pack-reused 4
Unpacking objects: 100% (54/54), 9.88 KiB | 1.65 MiB/s, done.
From https://github.com/NixOS/nixpkgs
   0a907ad8488..1f8ef6970a1  master     -> refs/nixpkgs-review/0
$ git worktree add /home/thiago/.cache/nixpkgs-review/rev-0a907ad84884de0d6a65dba8484fb95d302d4b46-dirty-2/nixpkgs 1f8ef6970a146c49a601bec2a7750c3f560e1206
Preparing worktree (detached HEAD 1f8ef6970a1)
HEAD is now at 1f8ef6970a1 linux: 5.9.12 -> 5.9.14
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-0a907ad84884de0d6a65dba8484fb95d302d4b46-dirty-2/nixpkgs -qaP --xml --out-path --show-trace
Applying `nixpkgs` diff...
$ nix-env -f /home/thiago/.cache/nixpkgs-review/rev-0a907ad84884de0d6a65dba8484fb95d302d4b46-dirty-2/nixpkgs -qaP --xml --out-path --show-trace --meta
2 packages updated:
f3d vtk

$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/thiago/.cache/nixpkgs-review/rev-0a907ad84884de0d6a65dba8484fb95d302d4b46-dirty-2/build.nix
2 packages built:
f3d vtk_9

@tfmoraes
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Dec 13, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot requested a review from kevincox December 13, 2020 21:20
@kevincox kevincox merged commit da5e0d3 into NixOS:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincox kevincox kevincox approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfmoraes @kevincox