Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hal-hardware-analyzer: 2.0.0 -> 3.1.9 #106691

Merged
merged 1 commit into from Dec 12, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Dec 11, 2020

Motivation for this change

Bump, allows me to remove requirement for libsForQt514 as requested in #104474

Tested non-nixos linux x86_64 & macos 10.14

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review on x86_64-linux:
https://github.com/NixOS/nixpkgs/pull/106691
1 package built:
hal-hardware-analyzer
[nix-shell:~/.cache/nixpkgs-review/pr-106691]$ hal
cli options

generic options
  --help, -h                          print help messages
  --version, -v                       displays the current version
  --show-log-options, -L              show all logging options
  --logfile, -l arg                   specify log file name
  --log-time                          includes time information into the log
  --licenses                          Shows the licenses of projects used
                                       by HAL
  --input-file, -i ARG                input file
  --gate-library, -gl ARG             used gate-library of the netlist
  --empty-netlist, -e                 create a new empty netlist, requires
                                       a gate library to be specified
  --volatile-mode                     [cli only] prevents hal from creating
                                       a .hal progress file (e.g. cluster
                                       use)
  --no-log                            prevents hal from creating a .log file
  --write-hdl ARG                     Write netlist to HDL file

plugin options

  --gui, -g                           start graphical user interface

  --dataflow                          executes the plugin dataflow
  --path arg                          provide path where results should be
                                       stored
  --layer arg                         (optional) layers per pipeline
                                       (default = 2)
  --sizes arg                         (optional) sizes which should be
                                       prioritized

  --python                            start python shell
  --python-script ARG                 run a python script in HAL. to pass
                                       args use --python-args
  --py-args, --python-args ARG        supply arguments to the python
                                       invocation. to provide multiple
                                       arguments use '"' and separate them
                                       with spaces



[nix-shell:~/.cache/nixpkgs-review/pr-106691]$ hal -g
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/hal_gui.so'...
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/vhdl_verilog_writers.so'...
[gate_library_manager] [info] registered gate library writer 'Default Verilog Writer' for file type '.v'
[gate_library_manager] [info] registered gate library writer 'Default VHDL Writer' for file type '.vhd'
[gate_library_manager] [info] registered gate library writer 'Default VHDL Writer' for file type '.vhdl'
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/graph_algorithm.so'...
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/dataflow.so'...
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/liberty_parser.so'...
[gate_library_manager] [info] registered gate library parser 'Default Liberty Parser' for file type '.lib'
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/netlist_simulator.so'...
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/python_shell.so'...
[core] [info] loading plugin '/nix/store/k7ifhaap5flnb74y91jd9qmsgmdhizqn-hal-hardware-analyzer-3.1.9/lib/hal_plugins/vhdl_verilog_parsers.so'...
[hdl_parser] [info] registered hdl parser 'Default Verilog Parser' for file type '.v'
[hdl_parser] [info] registered hdl parser 'Default VHDL Parser' for file type '.vhd'
[hdl_parser] [info] registered hdl parser 'Default VHDL Parser' for file type '.vhdl'
[core] [info] executing 'hal_gui' with
[core] [info]   '--gui': 

I ran it on a headless machine so I can't test the GUI beyond this.

@risicle risicle merged commit 41c8f3c into NixOS:master Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants