Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpsbabel: 1.6.0 -> 1.7.0 #106693

Closed
wants to merge 2 commits into from
Closed

gpsbabel: 1.6.0 -> 1.7.0 #106693

wants to merge 2 commits into from

Conversation

rycee
Copy link
Member

@rycee rycee commented Dec 11, 2020

Motivation for this change

Switch to libsForQt5 for #104474.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Dec 12, 2020

I don't think there's any such thing as plain libusb in all-packages.nix. There's libusb1 or libusb-compat-0_1. This is causing the eval error.

@risicle
Copy link
Contributor

risicle commented Dec 12, 2020

Also think this might be broken on darwin - it's giving me

clang++    main.o globals.o route.o waypt.o filter_vecs.o util.o vecs.o mkshort.o csv_util.o strptime.o grtcirc.o util_crc.o xmlgeneric.o formspec.o xmltag.o cet.o cet_util.o fatal.o rgbcolors.o inifile.o garmin_fs.o units.o gbser_posix.o gbser.o gbfile.o parse.o session.o src/core/textstream.o src/core/usasciicodec.o src/core/xmlstreamwriter.o  jeeps/gpsapp.o jeeps/gpscom.o jeeps/gpsmath.o jeeps/gpsmem.o jeeps/gpsprot.o jeeps/gpsread.o jeeps/gpsdevice.o jeeps/gpsdevice_ser.o jeeps/gpsdevice_usb.o jeeps/gpsrqst.o jeeps/gpssend.o jeeps/gpsserial.o jeeps/jgpsutil.o jeeps/gpsusbread.o jeeps/gpsusbsend.o jeeps/gpsusbcommon.o jeeps/gpslibusb.o shapelib/shpopen.o shapelib/dbfopen.o shapelib/safileio.o magproto.o gpx.o geo.o mapsend.o garmin.o garmin_device_xml.o garmin_tables.o internal_styles.o nmea.o kml.o wbt-200.o ozi.o pcx.o gdb.o gtrnctr.o xcsv.o explorist_ini.o gtm.o gpsutil.o skytraq.o holux.o tmpro.o tpg.o tpo.o tiger.o easygps.o saroute.o navicache.o delgpl.o text.o html.o netstumbler.o igc.o brauniger_iq.o shape.o hiketech.o glogbook.o vcf.o lowranceusr.o an1.o tomtom.o tef_xml.o maggeo.o vitosmt.o bcr.o ignrando.o stmwpp.o cst.o nmn4.o compegps.o yahoo.o unicsv.o wfff_xml.o garmin_txt.o gpssim.o stmsdf.o dmtlog.o raymarine.o alan.o vitovtt.o ggv_log.o g7towin.o garmin_gpi.o lmx.o random.o xol.o dg-100.o navilink.o mtk_logger.o ik3d.o osm.o destinator.o exif.o vidaone.o igo8.o gopal.o humminbird.o mapasia.o gnav_trl.o navitel.o ggv_ovl.o jtr.o sbp.o sbn.o mmo.o skyforce.o itracku.o v900.o pocketfms_bc.o pocketfms_fp.o pocketfms_wp.o naviguide.o enigma.o vpl.o teletype.o jogmap.o bushnell.o bushnell_trl.o wintec_tes.o subrip.o garmin_xt.o garmin_fit.o mtk_locus.o googledir.o mapbar_track.o f90g_track.o mapfactor.o energympro.o mynav.o ggv_bin.o globalsat_sport.o geojson.o qstarz_bl_1000.o bend.o position.o radius.o duplicate.o arcdist.o polygon.o smplrout.o reverse_route.o sort.o stackfilter.o trackfilter.o discard.o nukedata.o interpolate.o transform.o height.o swapdata.o validate.o  -lz -lm  -Wl,-rpath, /nix/store/c8fh14gnkapq0vjxlpjdw5ms9jbb9d9j-qtbase-5.12.7/lib -F/nix/store/c8fh14gnkapq0vjxlpjdw5ms9jbb9d9j-qtbase-5.12.7/lib -framework QtCore -Lmac/libusb -lusb-1.0 -lobjc -framework IOKit -framework CoreFoundation -o gpsbabel
ld: framework not found QtCore

on macos 10.14. Which is weird because it looks like the -F path is right there.

@rycee
Copy link
Member Author

rycee commented Dec 12, 2020

Thanks, I've simplified the PR to not include the version bump, which seems quite involved.

@risicle
Copy link
Contributor

risicle commented Dec 12, 2020

I just looked up in hydra and noticed gpsbabel has been broken on darwin for ages, and you should probably ignore me.

I no longer use this package and do not have the time to maintain it.
@rycee
Copy link
Member Author

rycee commented Dec 12, 2020

No worries. Rebased to master in e6781c2.

@rycee rycee closed this Dec 12, 2020
@rycee rycee deleted the bump/gpsbabel branch July 6, 2021 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants