Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gauche: 0.9.9 → 0.9.10 #106679

Merged
merged 1 commit into from Jan 11, 2021
Merged

gauche: 0.9.9 → 0.9.10 #106679

merged 1 commit into from Jan 11, 2021

Conversation

siraben
Copy link
Member

@siraben siraben commented Dec 11, 2020 •
edited

Motivation for this change

So that r-ryantm can update automatically in the future. I tried bumping the version but would involve some changes to the build process.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mnacamura December 11, 2020 20:02
@siraben
Copy link
Member Author

siraben commented Dec 11, 2020

Result of nixpkgs-review pr 106679 1

1 package failed to build:
  • gauche

mnacamura
mnacamura suggested changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@mnacamura mnacamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build gauche from the source fetched from github, you need to run ./DISET gen beforehand. Have a look at https://github.com/shirok/Gauche/blob/master/HACKING.adoc.

pkgs/development/interpreters/gauche/default.nix Show resolved Hide resolved
@siraben
Copy link
Member Author

siraben commented Dec 12, 2020

Build fails on darwin with

GAUCHE_LOAD_PATH="" GAUCHE_DYNLOAD_PATH="" "gosh"  -l./preload -I../src -I../lib -I../lib `cat ./features.flags` geninsn ./vminsn.scm
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gosh: command not found
grep '^#define GC_[0-9A-Z_]*THREADS' ../gc/include/config.h >> gauche/config_threads.h || :
make[1]: *** [Makefile:282: gauche/vminsn.h] Error 127
make[1]: *** Waiting for unfinished jobs....
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gosh: command not found
make[1]: *** [Makefile:279: gauche/priv/builtin-syms.h] Error 127
/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gosh: command not found
make[1]: *** [Makefile:282: vminsn.c] Error 127
make[1]: Leaving directory '/private/tmp/nix-build-gauche-0.9.9.drv-0/source/src'
make: *** [Makefile:45: all] Error 1
builder for '/nix/store/556vk76mwbic7rkhjciv3kjkckh750b6-gauche-0.9.9.drv' failed with exit code 2
error: build of '/nix/store/556vk76mwbic7rkhjciv3kjkckh750b6-gauche-0.9.9.drv' failed

@mnacamura setting autoreconfPhase doesn't seem to resolve it.

@mnacamura
Copy link
Contributor 

/nix/store/drz9yxh2v1swn9yl88c8w5g0x69b8wk2-bash-4.4-p23/bin/bash: gosh: command not found

Looks like gauche itself is required to build gauche.

@mnacamura
Copy link
Contributor

So we need to use another gauche for bootstrap. How about to copy old default.nix to another file, say boot.nix, and add (callPackage ./boot.nix {}) to nativeBuildInputs?

@siraben siraben mentioned this pull request Dec 12, 2020
Open
@ofborg ofborg bot requested a review from mnacamura December 12, 2020 10:09
@siraben siraben changed the title gauche: change src to GitHub gauche: 0.9.9 → 0.9.10 Dec 12, 2020
@siraben
Copy link
Member Author

siraben commented Dec 12, 2020

Build suceeds on x86_64-linux but fails on macOS due to outdated SDK.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106679 run on x86_64-linux 1

1 package failed to build and are new build failure:
  • gauche: log was empty
1 package built:
  • gaucheBootstrap
hash mismatch in fixed-output derivation '/nix/store/jhknprva2hmv0svdvnzrz4hgi4k6xm75-source':
  wanted: sha256:1lnfhywj3p3708qxsjqr6qp0dw68fx5lvj1djbsrd213w59p1v51
    got:    sha256:0ki1w7sa10ivmg51sqjskby0gsznb0d3738nz80x589033km5hmb

@ofborg ofborg bot requested a review from mnacamura January 8, 2021 02:21
@SuperSandro2000
Copy link
Member

You forgot to squash the commits.

@siraben siraben force-pushed the gauche-update branch 3 times, most recently from 8696447 to 0361f9d Compare January 10, 2021 14:17
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106679 run on x86_64-darwin 1

1 package failed to build and are new build failure:
1 package built:
  • gaucheBootstrap

@siraben
Copy link
Member Author

siraben commented Jan 11, 2021 •
edited

Unfortunately this looks like another missing symbol due to our macOS SDK being outdated.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106679 run on x86_64-linux 1

2 packages built:
  • gauche
  • gaucheBootstrap

@SuperSandro2000 SuperSandro2000 merged commit 3e5207b into NixOS:master Jan 11, 2021
@siraben siraben deleted the gauche-update branch January 11, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnacamura mnacamura Awaiting requested review from mnacamura

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siraben @mnacamura @SuperSandro2000