Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksmoothdock: qt514 -> qt515 (fix build) #106678

Merged
merged 1 commit into from Dec 30, 2020
Merged

ksmoothdock: qt514 -> qt515 (fix build) #106678

merged 1 commit into from Dec 30, 2020

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#104474

Things done

Patched 6.2 to build with qt515

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh reviewed Dec 11, 2020
View reviewed changes
pkgs/applications/misc/ksmoothdock/default.nix Outdated
@@ -25,6 +25,7 @@ mkDerivation rec {
url = "https://github.com/dangvd/ksmoothdock/commit/00799bef8a1c1fe61ef9274866267d9fe9194041.patch";
sha256 = "1nmb7gf1ggzicxz8k4fd67xhwjy404myqzjpgjym66wqxm0arni4";
})
./qt515.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this patch come from? Please use git format-patch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe contribute it upstream? Even if they won't accept it immediately, you can fetch it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done dangvd/ksmoothdock#123

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :) Now it would be great if you'd use fetchpatch and add a link in a comment to the PR. Also, use the following link:

https://github.com/dangvd/ksmoothdock/commit/1f4c94e289f078bdaba7bb165c5cf2a9f743076e.patch

@doronbehar doronbehar merged commit 1c090a5 into NixOS:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SCOTT-HAMILTON @FRidh @doronbehar