nixos/test-driver: Fix wait_for_window() when X is running as non-root #106686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, wait, something's wrong: The new sddm-flavor of the new test doesn't pass on master. I now realise I had only tested it on 20.09 before creating this PR. :( |
chkno
force-pushed
the
non-root-wait_for_window
branch
from
3aec879
to
80a0f79
Compare
|
Ok, it's fixed now. I switched from sddm to lightdm as the representative for sddm seems to have some unrelated problem on master where it stops the session before it finishes starting up. I don't want to block this wait_for_window() fix on figuring out what's wrong with sddm at the moment. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Make wait_for_window() work when X is running as non-root. (X shouldn't ever be running as root.)
Fixes #106685
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"FYI:
@pbogdan who explained the problem in #37642
@xeji who added allow-root-login in 5f72169
@adisbladis who added XAUTHORITY user-systemd import in 40f402c