Implement aspect-ratio interpolation support. #26856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2586234
branch
3 times, most recently
from
5d40f37
to
8bd0cf2
Compare
Based on the discussion in w3c/csswg-drafts#4953 aspect ratios should be interpolated by the log of their value preserving the same visual speed whether they are wide or narrow. This patch adds a new interpolation type for aspect ratios and uses it for interpolating the CSS aspect-ratio property. Bug: 1156160 Change-Id: I6cbff0abef54290de559a7625e24e3c4e1f1e0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586234 Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846135}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2586234
branch
from
8bd0cf2
to
2d07a87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in w3c/csswg-drafts#4953
aspect ratios should be interpolated by the log of their value preserving
the same visual speed whether they are wide or narrow.
This patch adds a new interpolation type for aspect ratios and uses it
for interpolating the CSS aspect-ratio property.
Bug: 1156160
Change-Id: I6cbff0abef54290de559a7625e24e3c4e1f1e0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586234
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#846135}