Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freenukum: init at 0.3.5 #106674

Merged
merged 1 commit into from Jan 1, 2021
Merged

freenukum: init at 0.3.5 #106674

merged 1 commit into from Jan 1, 2021

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Dec 11, 2020

Motivation for this change

Include freenukum into nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@0x4A6F 0x4A6F force-pushed the master-freenukum branch 3 times, most recently from d591bf2 to 9271299 Compare December 13, 2020 19:29
@0x4A6F 0x4A6F changed the title freenukum: init at 0.3.3 freenukum: init at 0.3.4 Dec 13, 2020
@0x4A6F 0x4A6F marked this pull request as ready for review December 13, 2020 19:49
@0x4A6F 0x4A6F changed the title freenukum: init at 0.3.4 freenukum: init at 0.3.5 Dec 20, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 106674 run on x86_64-darwin 1

1 package failed to build:
  • freenukum
error[E0425]: cannot find value `font_path` in this scope
  --> src/graphics.rs:20:20
   |
20 |         .load_font(font_path, 10)
   |                    ^^^^^^^^^ not found in this scope

error: aborting due to previous error

For more information about this error, try `rustc --explain E0425`.
error: could not compile `freenukum`

To learn more, run the command again with --verbose.
warning: build failed, waiting for other jobs to finish...
error: build failed

Please mark it broken on darwin.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106674 run on x86_64-linux 1

1 package built:
  • freenukum

SuperSandro2000
SuperSandro2000 requested changes Jan 1, 2021
View reviewed changes
pkgs/games/freenukum/default.nix Outdated
@@ -0,0 +1,70 @@
{ lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib
{ stdenv

pkgs/games/freenukum/default.nix Outdated
install -Dm644 "${desktopItem}/share/applications/"* -t $out/share/applications/
'';

meta = with lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with lib; {
meta = with stdenv.lib; {

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 1, 2021 •
edited

This is a semi-automatic executed nixpkgs-review. If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 106674 run on x86_64-linux 1

1 package built:
  • freenukum

@SuperSandro2000 SuperSandro2000 merged commit 5ea718c into NixOS:master Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0x4A6F @SuperSandro2000