[Scroll Timeline] Clamp overlapping offsets. #26869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 12, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2508356
branch
from
033d4cc
to
847101d
Compare
Updated procedure that computes scroll timeline progress to accommodate for overlapping offsets. The update is to find last matching interval in the list of offsets. This is analogous to CSS property overrides where last specified property is applied. Bug: 1094014 Change-Id: I7d5c84e58bfea021f931b702d66a87d2d28aaf6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508356 Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com> Reviewed-by: Kevin Ellis <kevers@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842367}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2508356
branch
from
847101d
to
28cce6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated procedure that computes scroll timeline progress to accommodate
for overlapping offsets. The update is to find last matching interval in
the list of offsets. This is analogous to CSS property overrides where
last specified property is applied.
Bug: 1094014
Change-Id: I7d5c84e58bfea021f931b702d66a87d2d28aaf6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508356
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#842367}