Fix package position links #242
Conversation
ncfavier
force-pushed
the
fix-package-position-links
branch
from
8d8f8a4
to
034de95
Compare
ncfavier
force-pushed
the
fix-package-position-links
branch
from
034de95
to
df8793c
Compare
|
Oops, I tried bumping the version in |
|
Noted. |
|
@ncfavier Sorry I wrote to fast before. The VERSION change lets us test - alongside existing search index. Most of the time I only used this when index schema changed and bigger changes. But we do have to run the import manually. |
|
Ok, I assume it's something you have to do? |
|
yes, sadly, It would be nice to automate this somehow. |
| @@ -462,7 +462,7 @@ def gen(): | |||
|
|
|||
| position = data["meta"].get("position") | |||
| if position and position.startswith("/nix/store"): | |||
| position = position[44:] | |||
| position = position.split("/", 4)[-1] | |||
There was a problem hiding this comment.
I think some time ago this was actually working. but then something changed in nixpkgs and source/ was added. It think we need to be a little more defensive here. I would only remove source/ and nothing else. We definetly dont want to rely on structure here.
position = position[44:]
if position.startswith('source/'):
position = position[len('source/'):]
or something similar
There was a problem hiding this comment.
But then things will break again if source/ changes to src/ or whatnot. I think we can reasonably rely on the fact that it will always look like /nix/store/hash-name/actual_path_in_nixpkgs, and therefore stripping the first three path components should be enough.
|
I'll import the channels manually and then merge this. |
Splitting at the 44th character means leaving the
source/part which is not part of GitHub nixpkgs URLs. All "Nix expression" links in the package search are currently broken because of this.This fix strips the first three path components instead (
/nix/store/...-source).