Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition of nasirhm in maintainers #105585

Merged
merged 2 commits into from Dec 1, 2020
Merged

Addition of nasirhm in maintainers #105585

merged 2 commits into from Dec 1, 2020

Conversation

nasirhm
Copy link
Contributor

@nasirhm nasirhm commented Dec 1, 2020

Motivation for this change

Add nasirhm in maintainers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@RaghavSood
Copy link
Member

Please format your commit message as maintainers: add nasirhm

If you plan to take maintainership of some packages, you should consider adding yourself to the maintainer list for those in separate commits as well.

Additionally, note that you don't need to be in the maintainer list to contribute - PRs are welcome regardless, the maintainerlist is just a way for the CI tools and other contributors to know who to request reviews from for package updates and questions

@nasirhm nasirhm mentioned this pull request Dec 1, 2020
Merged
2 tasks
@nasirhm
maintainers: add nasirhm
b8ad6ef 
Signed-off-by: nasirhm <nasirhussainm14@gmail.com>
@nasirhm
brave-browser: add maintainer nasirhm
6344197 
Signed-off-by: nasirhm <nasirhussainm14@gmail.com>
@nasirhm
Copy link
Contributor Author

nasirhm commented Dec 1, 2020

Please format your commit message as maintainers: add nasirhm

Done, Thanks :D

If you plan to take maintainership of some packages, you should consider adding yourself to the maintainer list for those in separate commits as well.

I added myself as a maintainer for brave browser (As I use it myself and have previously version bumped it).

Additionally, note that you don't need to be in the maintainer list to contribute - PRs are welcome regardless, the maintainerlist is just a way for the CI tools and other contributors to know who to request reviews from for package updates and questions

Hmm, Thanks for the review @RaghavSood

@RaghavSood RaghavSood merged commit 86b651f into NixOS:master Dec 1, 2020
@nasirhm nasirhm deleted the add_nasirhm_maintainer branch December 1, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaghavSood RaghavSood RaghavSood approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nasirhm @RaghavSood