Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/installation-device: replace wpa_supplicant by iwd #105561

Closed
wants to merge 1 commit into from
Closed

nixos/installation-device: replace wpa_supplicant by iwd #105561

wants to merge 1 commit into from
+4 −4

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Dec 1, 2020 •
edited
Loading

Motivation for this change

This a draft pr for #105560
Sill need to figure out how this interacts with other iso images, that build on top of installation-device.nix.
This will make all images, that do not build on top of installation-cd-graphical-base use iwd, since installation-cd-graphical-base is the only one referencing network-manager.

Things done

Built the minimal iso image with this and #105559 applied, closure size went down by 3M.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 1, 2020
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/better-wifi-ux-on-the-non-graphical-installer/23030/24

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 9, 2022
@ofborg ofborg bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 9, 2022
@xaverdh xaverdh requested a review from rnhmjoj November 13, 2022 08:23
@xaverdh xaverdh marked this pull request as ready for review November 13, 2022 13:07
@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 18, 2023
@SuperSandro2000
Copy link
Member

Gnome and Plasma use NetworkingManager which booth require wpa_supplicant. I don't think we should use something different in the smaller iso.

I am inclined to close this.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 26, 2023
@xaverdh
Copy link
Contributor Author

xaverdh commented Nov 26, 2023

Why should we not use something different in the minimal iso?
iwd is quite a better fit for a minimal image compared to networkmanager, I think.
I guess consistency between images could be worth something, just not that much in my opinion.

@xaverdh
Copy link
Contributor Author

xaverdh commented Nov 26, 2023

But feel free to close this if you want. I don't actively work on pushing this anyway.

@Weathercold
Copy link
Member

Gnome and Plasma use NetworkingManager which booth require wpa_supplicant.

Can’t NetworkManager use the iwd backend on Gnome and Plasma? (although it’s still experimental)

@SuperSandro2000
Copy link
Member

I guess consistency between images could be worth something, just not that much in my opinion.

It requires us to test less and makes debugging issues easier and instructions for all image variants are the same.

Can’t NetworkManager use the iwd backend on Gnome and Plasma? (although it’s still experimental)

Then that is something we should definitely not set by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xaverdh @nixos-discourse @SuperSandro2000 @Weathercold