New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cacert: fix certificate denylist #105568
Merged
Merged
cacert: fix certificate denylist #105568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will need a backport to 20.09, I think. |
...and I'll need to retarget this at staging. |
lukegb
force-pushed
the
nixpkgs-cacert-blacklist
branch
from
December 1, 2020 10:37
b40c137
to
d95f30a
Compare
lukegb
requested review from
cdepillabout,
Ericson2314,
FRidh,
jonringer,
matthewbauer and
stigtsp
as code owners
December 1, 2020 10:37
lukegb
force-pushed
the
nixpkgs-cacert-blacklist
branch
from
December 1, 2020 10:37
d95f30a
to
73b488f
Compare
andir
requested changes
Dec 1, 2020
lukegb
force-pushed
the
nixpkgs-cacert-blacklist
branch
from
December 1, 2020 12:14
73b488f
to
03b7eb9
Compare
andir
reviewed
Dec 1, 2020
lukegb
force-pushed
the
nixpkgs-cacert-blacklist
branch
from
December 1, 2020 14:33
03b7eb9
to
277df9b
Compare
andir
reviewed
Dec 1, 2020
mweinelt
added
the
9.needs: port to stable
A PR needs a backport to the stable release.
label
Dec 1, 2020
It's broken under Python 3, ironically due to the patch we're carrying. Fix it, and add a test to check it works. Fixes NixOS#93230.
This doesn't do anything. Building with includeEmail = true produces the same set as includeEmail = false, and the substitute rule removes a random dictionary index operation.
lukegb
force-pushed
the
nixpkgs-cacert-blacklist
branch
from
December 1, 2020 15:55
f33ccaf
to
b28436a
Compare
lukegb
commented
Dec 1, 2020
@lukegb welcome to the maintainers club for cacerts ;) Mind opening a PR with this change against staging-20.09? |
10 tasks
erictapen
added
8.has: port to stable
A PR already has a backport to the stable release.
and removed
9.needs: port to stable
A PR needs a backport to the stable release.
labels
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: port to stable
A PR already has a backport to the stable release.
10.rebuild-darwin: 501+
10.rebuild-darwin: 1001-2500
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
11.by: package-maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's broken under Python 3, ironically due to the patch we're carrying.
Fix it, and add a "test" to make sure it at least builds.
Fixes #93230.
This also removes the
includeEmail
option, because it doesn't do anything.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)