Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makeBootstrapTools: set schedulingPriority #105699

Merged
merged 1 commit into from Dec 2, 2020
Merged

makeBootstrapTools: set schedulingPriority #105699

merged 1 commit into from Dec 2, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Dec 2, 2020

Increase schedulingPriority of the bootstrap tools to unblock the
nixpkgs-unstable channel.

The channel is repeatedly blocked by the makeBootstrapTools job for
aarch64. The cause is lack of resources.

By increasing the priority, it should become the first job Hydra would
build, allowing the channel to advance quicker. Of course, it does mean
that while the channel advances, nothing else has been built.

This should be a temporary solution until we have more capacity for
aarch64.

Motivation for this change

Alternative to #104679.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @samueldr @grahamc @vcunat @mweinelt

@FRidh
makeBootstrapTools: set schedulingPriority
d92008a 
Increase schedulingPriority of the bootstrap tools to unblock the
nixpkgs-unstable channel.

The channel is repeatedly blocked by the makeBootstrapTools job for
aarch64. The cause is lack of resources.

By increasing the priority, it should become the first job Hydra would
build, allowing the channel to advance quicker. Of course, it does mean
that while the channel advances, nothing else has been built.

This should be a temporary solution until we have more capacity for
aarch64.
@FRidh FRidh merged commit 1649296 into NixOS:master Dec 2, 2020
@vcunat
Copy link
Member

vcunat commented Dec 2, 2020

I must admit I don't understand how this should work. I believe any channel won't advance until all builds in the corresponding evaluation finish (and the special subset succeeds).

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2020

I must admit I don't understand how this should work. I believe any channel won't advance until all builds in the corresponding evaluation finish (and the special subset succeeds).

This is for aarch64, and there is only these two jobs in the channel for them. Thus, if within the jobset and arch, these two gets put to the front, the channel should advance quicker.

@FRidh
Copy link
Member Author

FRidh commented Dec 2, 2020

No, definitely not all jobs.

@FRidh
Copy link
Member Author

FRidh commented Dec 3, 2020 •
edited

Seems though that the channel did advance 3 days ago.

Deciphering the channel update script https://github.com/NixOS/nixos-channel-scripts/blob/master/mirror-nixos-branch.pl

Called from https://github.com/NixOS/nixos-org-configurations/blob/master/modules/hydra-mirror.nix

Release url is nixpkgs/trunk/unstable as defined in channels.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @vcunat