Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mindustry: mark broken for darwin, 120 -> 120.2 #105692

Merged
merged 2 commits into from Dec 2, 2020
Merged

mindustry: mark broken for darwin, 120 -> 120.2 #105692

merged 2 commits into from Dec 2, 2020

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Dec 2, 2020

Motivation for this change

#105590 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105692 run on x86_64-linux 1

2 packages built:
  • mindustry
  • mindustry-server

@SuperSandro2000 SuperSandro2000 merged commit 0278e49 into NixOS:master Dec 2, 2020
@fgaz fgaz deleted the mindustry/120.2 branch December 2, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fgaz @SuperSandro2000