Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libmanette: 0.2.5 -> 0.2.6 #105708

Merged
merged 1 commit into from Dec 2, 2020
Merged

libmanette: 0.2.5 -> 0.2.6 #105708

merged 1 commit into from Dec 2, 2020

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Dec 2, 2020

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for libmanette is: "A simple GObject game controller library"

meta.homepage for libmanette is: "https://gitlab.gnome.org/aplazas/libmanette"

meta.changelog for libmanette is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
7 total rebuild path(s)

2 package rebuild(s)

2 x86_64-linux rebuild(s)
2 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
2 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
gnome3.quadrapassel
libmanette
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/kxszkyg13drzgzvykpsqwnlaim0ki102-libmanette-0.2.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A libmanette https://github.com/r-ryantm/nixpkgs/archive/eac29ec45902deb87f63d8782ce2b7c10d545617.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/kxszkyg13drzgzvykpsqwnlaim0ki102-libmanette-0.2.6
ls -la /nix/store/kxszkyg13drzgzvykpsqwnlaim0ki102-libmanette-0.2.6/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review 1

2 packages built:
  • gnome3.quadrapassel
  • libmanette
Maintainer pings

cc @hedning @jtojnar @worldofpeace @dasj19 for testing.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 2, 2020 •
edited

Changes:

Version 0.2.6

  • Project:
  • Documentation:
    • Add a documentation.
    • Fix many documentation annotations.
    • Document more symbols.
  • Meson:
    • Require Meson 0.53.0.
    • Add the demos option.
    • Add the build-tests and install-tests option.
    • Various code style cleanups and updates.
    • Add a build summary.
  • ManetteDevice:
    • Add a missing precondition check to ensure milliseconds is in the
      right range in manette_device_rumble().
    • Throw the full file error code rather than G_FILE_ERROR_FAILED in
      manette_device_new().
    • Throw G_FILE_ERROR_FAILED rather than G_FILE_ERROR_NXIO in
      manette_device_new() if the device isn't a gamepad.
  • ManetteMapping:
    • Check mapping strings have at least a GUID field and a name field.
    • Use the debug log level for non-programming mapping parsing errors.
    • Make some parsing error messages more explicit.
  • ManetteMappingManager:
    • Use a race-free way to check the mapping file deletion.
  • Code cleanup:
    • Make license headers have the LGPL footer, not the GPL one.
    • Use #pragma once instead of manual header guards.
    • Use g_auto(), g_autoptr() and g_autofree where possible.
    • Use g_clear_pointer() and g_clear_object() where possible.
    • Use assertions instead of g_return*_if_fail in static functions.
    • Add HACKING.md to document the code, documentation, and commit
      message styles.
    • Give better names to callback functions.
    • Give the namespace_object_ prefix to the finalize functions to match
      the code style.
    • Clean up and simplify the code in many places.
    • Drop platform:Linux from the internal gamepad database.

@jtojnar jtojnar added the 8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. label Dec 2, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105708 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • libmanette

@SuperSandro2000 SuperSandro2000 merged commit ed23e84 into NixOS:master Dec 2, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105708 run on x86_64-linux 1

2 packages built:
  • gnome3.quadrapassel
  • libmanette

@r-ryantm r-ryantm deleted the auto-update/libmanette branch December 3, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
8.has: upstream changes reviewed Reviewer checked the changelogs/commit logs associated with the release and did not find any issues. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-ryantm @jtojnar @SuperSandro2000