Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: updates #105693

Merged
merged 1 commit into from Dec 2, 2020
Merged

jetbrains: updates #105693

merged 1 commit into from Dec 2, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Dec 2, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof requested a review from edwtjo as a code owner December 2, 2020 13:08
@ofborg ofborg bot requested review from baldo and rasendubi December 2, 2020 13:18
@raboof
Copy link
Member Author

raboof commented Dec 2, 2020

Result of nixpkgs-review pr 105693 1

7 packages built:
  • jetbrains.idea-community
  • jetbrains.idea-ultimate
  • jetbrains.mps
  • jetbrains.pycharm-community
  • jetbrains.pycharm-professional
  • jetbrains.ruby-mine
  • jetbrains.webstorm

@raboof
Copy link
Member Author

raboof commented Dec 2, 2020

manually tested building and testing a Scala project in idea-community works 👍

@edwtjo edwtjo merged commit 3eb7f01 into NixOS:master Dec 2, 2020
@raboof
Copy link
Member Author

raboof commented Dec 2, 2020

@edwtjo wow that was quick - thanks for the merge, and good to see you back ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

@baldo baldo Awaiting requested review from baldo

@rasendubi rasendubi Awaiting requested review from rasendubi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @edwtjo