Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: convert packages/linux docbook -> commonmark #105712

Closed
wants to merge 1 commit into from
Closed

docs: convert packages/linux docbook -> commonmark #105712

wants to merge 1 commit into from

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Dec 2, 2020

Motivation for this change

Closes #105257, conversion of Docbook Packages for Linux to CommonMark.

@ryantm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ryantm
ryantm approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and rendering comparison look good; thanks!

ryantm
ryantm requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I just noticed the editorconfig was failing. There is some trailing whitespace on line 30 of your md file. Could you remove that?

@ryantm ryantm mentioned this pull request Dec 3, 2020
Merged
@ryantm
Copy link
Member

ryantm commented Dec 3, 2020

Closing in favor of #105752 where the trailing whitespace is fixed.

@ryantm ryantm closed this Dec 3, 2020
@mmlb
Copy link
Contributor Author

mmlb commented Dec 4, 2020

@ryantm Odd, thanks for handling it!

@mmlb mmlb deleted the docbook2commonmark-packages-linux branch April 11, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm requested changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Convert Linux from Docbook to CommonMark
2 participants
@mmlb @ryantm