Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmtc: init at 0.2.6 #105702

Closed
wants to merge 4 commits into from
Closed

mmtc: init at 0.2.6 #105702

wants to merge 4 commits into from

Conversation

figsoda
Copy link
Member

@figsoda figsoda commented Dec 2, 2020 •
edited

Motivation for this change

mmtc is a minimal mpd terminal client that aims to be simple yet highly configurable

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@figsoda
Copy link
Member Author

figsoda commented Dec 2, 2020

Result of nixpkgs-review pr 105702 run on x86_64-linux 1

1 package built:
  • mmtc

@figsoda
Copy link
Member Author

figsoda commented Dec 2, 2020

Ofborg didn't seem to like it.

This PR does not cleanly list package outputs after merging.

What does it mean? What can I do to fix it?

SuperSandro2000
SuperSandro2000 reviewed Dec 2, 2020
View reviewed changes
pkgs/applications/audio/mmtc/default.nix Outdated
"Minimal mpd terminal client that aims to be simple yet highly configurable";
homepage = "https://github.com/figsoda/mmtc";
license = licenses.mpl20;
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing maintainers and platforms.

@figsoda
maintainers: add figsoda
c75f121
@figsoda
mmtc: add maintainers
3236f9e
@figsoda
mmtc: add meta.changelog and meta.platforms
8775c44 
I'm not sure what platforms exactly is it going to work on,
so it's set to platforms.all so I can know which ones work
@figsoda
Copy link
Member Author

figsoda commented Dec 2, 2020

Ofborg still says the same thing. Does it have something to do with nixpkgs-mozilla? Since it depends on the nightly version of rust.

SuperSandro2000
SuperSandro2000 reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your mmtc related commits together.

pkgs/applications/audio/mmtc/default.nix
rust = (let
mozilla = fetchFromGitHub {
owner = "mozilla";
repo = "nixpkgs-mozilla";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is acceptable in nixpkgs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is acceptable in nixpkgs.

I guess that's why, I will close this then

@figsoda figsoda closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@figsoda @SuperSandro2000 @Janik-Haag