Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update openrazer from v2.8.0 to v2.9.0 and solve #105576 #105695

Merged
merged 1 commit into from Dec 2, 2020
Merged

Update openrazer from v2.8.0 to v2.9.0 and solve #105576 #105695

merged 1 commit into from Dec 2, 2020

Conversation

d4g
Copy link
Contributor

@d4g d4g commented Dec 2, 2020 •
edited by prusnak

Motivation for this change

Bump version of openrazer from v2.8.0 to v2.9.0 to support new released hardware.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d4g d4g mentioned this pull request Dec 2, 2020
Closed
2 tasks
@ofborg ofborg bot requested review from evanjs and roelvandijk December 2, 2020 13:52
prusnak
prusnak requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md the commit message should be: python3Packages.openrazer: 2.8.0 -> 2.9.0

Can you please change this?

@d4g
Copy link
Contributor Author

d4g commented Dec 2, 2020

@prusnak I changed the commit message.

@prusnak
Copy link
Member

prusnak commented Dec 2, 2020

@GrahamcOfBorg build python3Packages.openrazer

@prusnak
Copy link
Member

prusnak commented Dec 2, 2020

$ nixpkgs-review pr 105695

23 packages built:
linuxPackages-libre.openrazer linuxPackages.openrazer linuxPackages_4_14.openrazer linuxPackages_4_19.openrazer linuxPackages_4_4.openrazer linuxPackages_4_9.openrazer linuxPackages_5_8.openrazer linuxPackages_5_9.openrazer linuxPackages_hardened.openrazer linuxPackages_latest-libre.openrazer linuxPackages_latest_hardened.openrazer linuxPackages_latest_xen_dom0.openrazer linuxPackages_latest_xen_dom0_hardened.openrazer linuxPackages_testing_bcachefs.openrazer linuxPackages_xen_dom0.openrazer linuxPackages_xen_dom0_hardened.openrazer linuxPackages_zen.openrazer openrazer-daemon python37Packages.openrazer python37Packages.openrazer-daemon python38Packages.openrazer python39Packages.openrazer python39Packages.openrazer-daemon

@prusnak prusnak merged commit 5e402a3 into NixOS:master Dec 2, 2020
@prusnak
Copy link
Member

prusnak commented Dec 2, 2020

Thanks @d4g !

@prusnak prusnak linked an issue Dec 2, 2020 that may be closed by this pull request
openrazer v2.8.0 -> v2.9.0 #105576
Closed
2 tasks
@d4g
Copy link
Contributor Author

d4g commented Dec 2, 2020

Thanks @prusnak for showing the way :)

@SuperSandro2000
Copy link
Member

$ nixpkgs-review pr 105695

23 packages built:
linuxPackages-libre.openrazer linuxPackages.openrazer linuxPackages_4_14.openrazer linuxPackages_4_19.openrazer linuxPackages_4_4.openrazer linuxPackages_4_9.openrazer linuxPackages_5_8.openrazer linuxPackages_5_9.openrazer linuxPackages_hardened.openrazer linuxPackages_latest-libre.openrazer linuxPackages_latest_hardened.openrazer linuxPackages_latest_xen_dom0.openrazer linuxPackages_latest_xen_dom0_hardened.openrazer linuxPackages_testing_bcachefs.openrazer linuxPackages_xen_dom0.openrazer linuxPackages_xen_dom0_hardened.openrazer linuxPackages_zen.openrazer openrazer-daemon python37Packages.openrazer python37Packages.openrazer-daemon python38Packages.openrazer python39Packages.openrazer python39Packages.openrazer-daemon

Can you please update your nixpkgs-review to let us know which platform you run it on?

@Narice
Copy link
Contributor

Narice commented Jan 23, 2021

Could this be backported to 20.09 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@evanjs evanjs Awaiting requested review from evanjs

@roelvandijk roelvandijk Awaiting requested review from roelvandijk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openrazer v2.8.0 -> v2.9.0
5 participants
@d4g @prusnak @SuperSandro2000 @Narice @Janik-Haag