Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ircstates: 0.11.5 -> 0.11.6; python3Packages.ircrobots: 0.3.5 -> 0.3.6 #105703

Merged
merged 2 commits into from Dec 2, 2020
Merged

python3Packages.ircstates: 0.11.5 -> 0.11.6; python3Packages.ircrobots: 0.3.5 -> 0.3.6 #105703

merged 2 commits into from Dec 2, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 2, 2020

Motivation for this change

New upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Dec 2, 2020 •
edited

Result of nixpkgs-review pr 105703 run on x86_64-linux 1

1 package failed to build:
  • python39Packages.ircrobots
5 packages built:
  • python37Packages.ircrobots
  • python37Packages.ircstates
  • python38Packages.ircrobots
  • python38Packages.ircstates
  • python39Packages.ircstates

Failure due to tests failing in python39Packages.astroid.

jonringer
jonringer approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/105703
1 package failed to build:
python39Packages.ircrobots

5 packages built:
python37Packages.ircrobots python37Packages.ircstates python38Packages.ircrobots python38Packages.ircstates python39Packages.ircstates

@jonringer
Copy link
Contributor

waiting for ofborg to finish

@jonringer jonringer merged commit 500490a into NixOS:master Dec 2, 2020
@mweinelt mweinelt deleted the updates branch December 2, 2020 15:56
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105703 run on x86_64-darwin 1

1 package failed to build:
  • python38Packages.ircrobots
5 packages built:
  • python37Packages.ircrobots
  • python37Packages.ircstates
  • python38Packages.ircstates
  • python39Packages.ircrobots
  • python39Packages.ircstates

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 105703 run on x86_64-linux 1

1 package failed to build:
  • python39Packages.ircrobots
5 packages built:
  • python37Packages.ircrobots
  • python37Packages.ircstates
  • python38Packages.ircrobots
  • python38Packages.ircstates
  • python39Packages.ircstates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @jonringer @SuperSandro2000