onnxruntime: remove #105951
onnxruntime: remove #105951
Conversation
Poor cmake and git hygiene has made maintaining this difficult, see: microsoft/onnxruntime#5966 microsoft/onnxruntime#5967
|
It could be interesting to resurrect onnxruntime to package https://github.com/royshil/obs-backgroundremoval, which is a pretty epic OBS Studio plugin. |
|
Well, if they make it so that you can import external resources, but it was annoying to have to checkout ~1GB of sources and dependencies for what should be ~4-12MB of source. https://github.com/microsoft/onnxruntime/blob/master/.gitmodules |
Very true. Your Nix expressions still work to build it though, even the latest version. Will look into reviving this when I get chance. Maybe things have improved. |
|
Also, they version control their testdata, which adds like 70MB, which is like 1/2 the checkout size. I asked if they could use lfs for testdata in microsoft/onnxruntime#5967. Also, they really need to be following cmake best practices for dependency management. For example https://github.com/microsoft/onnxruntime/blob/master/cmake/external/eigen.cmake should really be using something like |
|
@blitz coincidentally I started work on this tonight and got fairly far. |
Awesome! If you open a PR please tag me. |
|
@blitz works surprisingly well, I'll try to push my WIP tomorrow morning. |
Motivation for this change
I tried to bump this, jonringer@18255bd, but gave up.
Poor cmake and git hygiene has made maintaining this difficult, see:
microsoft/onnxruntime#5966
microsoft/onnxruntime#5967
I'm not aware of anyone using this package. I added it because it seemed like it may have been a more crucial ML package a year ago.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)