Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox/wrapper: use writeText instead of builtins.toFile #106825

Closed
wants to merge 1 commit into from
Closed

firefox/wrapper: use writeText instead of builtins.toFile #106825

wants to merge 1 commit into from

Conversation

xaverdh
Copy link
Contributor

@xaverdh xaverdh commented Dec 13, 2020

Motivation for this change

Allow policiesJson and mozillaCfg to depend on other derivations.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xaverdh xaverdh requested a review from Qubasa December 13, 2020 13:29
@Qubasa
Copy link
Contributor

Qubasa commented Dec 13, 2020 •
edited

Already in this pull request: #106000

@Qubasa Qubasa closed this Dec 13, 2020
@xaverdh
Copy link
Contributor Author

xaverdh commented Dec 13, 2020

ah didn't see that, sorry for the noise!

@Qubasa
Copy link
Contributor

Qubasa commented Dec 13, 2020 •
edited

Don't worry if you have time maybe give the pull request a review :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubasa Qubasa Awaiting requested review from Qubasa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xaverdh @Qubasa