Change: Don't display OS name when the user is exiting the game #8366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suggested by frosch: only change |
orudge
force-pushed
the
remove-os-exit
branch
from
4fc1555
to
3f01af3
Compare
|
Thanks for the suggestion - I've made that change now. |
TrueBrain
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not 1995 any more, just prompt the user if they want to exit the game.
This does result in build warnings because of the un-updated string using {STRING} in all the translations (the game then falls back to the English string for those languages). I'm not sure what the correct process here, but if I need to amend the patch, let me know.