New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] Backport Skype 8.66.0.74 from 21.03 release #106379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Diff LGTM
- Commits LGTM
- Builds via
nix-review
:
https://github.com/NixOS/nixpkgs/pull/106379
1 package built:
skypeforlinux
What should we do for the PR to be handled? |
It needs someone with committer access to merge this. I suggest either trying in the NixOS IRC or this thread on NixOS Discourse. https://discourse.nixos.org/t/prs-already-reviewed/2617 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (source code changes). Did not however launch the binary to see if it still does work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
gui launches fine
https://github.com/NixOS/nixpkgs/pull/106379
1 package built:
skypeforlinux
Motivation for this change
Backport newer Skype 8.66.0.74 for 20.09 release.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)